Fix error when processing job summaries that are marked as error. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add unit tests for the code change. Now have 100% code coverage for the function.
jpwhite4
force-pushed
the
summary_error_handler
branch
from
b8cf891
to
6c54696
Compare
plessbd
approved these changes
Apr 19, 2017
jtpalmer
added a commit
that referenced
this pull request
May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix php error when processing job summaries that had a wildcard schema entry, but the
corresponding summary entry was marked as error.
Also add unit tests for the code change. Now have 100% code coverage for
the function.
Motivation and Context
Bug fix
Tests performed
Created and ran unit tests.
Types of changes